tests/commands/staking.test.ts (1)

15-15: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Relative import instead of @/* alias.

New import uses ../../src/commands/staking/validators rather than the configured @/* alias, per the repo's coding guidelines. This matches the pre-existing style of every other import in this file, so it's a minor, low-priority inconsistency rather than a new pattern.

As per coding guidelines, "Use @/* path alias to reference ./src/* and @@/tests/* path alias to reference ./tests/* in imports."

Also applies to: 28-28

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/commands/staking.test.ts` at line 15, The new import in staking.test.ts
uses a relative path instead of the repository’s path aliases. Update the import
for ValidatorsAction (and the other affected import in this file) to use the
configured `@/`* alias for src references, matching the existing import style and
the repo’s import guidelines.

Source: Coding guidelines

tests/commands/stakingValidators.test.ts (2)

91-150: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Good coverage of chain-only and explorer-enriched paths; consider adding a failure-fallback test.

Both happy-path cases (no explorer, and explorer with sorting) are well covered and align with the execute() flow shown in the upstream snippet. However, the PR objective emphasizes "graceful fallback to chain-only data" when explorer enrichment is attempted but fails/unreachable — that specific fallback path isn't tested here (only the "no explorerUrl provided" case is).

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/commands/stakingValidators.test.ts` around lines 91 - 150, Add a test
for the failure fallback path in stakingValidators.execute(), where explorer
enrichment is attempted but the explorer request fails or is unreachable, and
verify it still emits chain-only JSON instead of throwing. Reuse the existing
setupAction() and JSON output assertions, but make fetchMock return a failed
response for the explorer endpoint(s) and assert the output matches the
chain-only shape with explorer.enabled false/null and validator
performance/delegator fields left unset or null.

---

1-2: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Use @/* alias for src import.

New test file imports ValidatorsAction via a relative path (../../src/commands/staking/validators) instead of the @/* alias mandated for .ts files.

As per coding guidelines, "Use @/* path alias to reference ./src/* and @@/tests/* path alias to reference ./tests/* in imports."

♻️ Proposed fix

-import {ValidatorsAction} from "../../src/commands/staking/validators";
+import {ValidatorsAction} from "`@/commands/staking/validators`";

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/commands/stakingValidators.test.ts` around lines 1 - 2, The test file
is importing ValidatorsAction with a relative src path instead of the required
alias. Update the import in stakingValidators.test.ts to use the `@/`* alias for
the src/commands/staking/validators module, keeping the rest of the test setup
unchanged and matching the project’s import conventions for .ts files.

Source: Coding guidelines

src/commands/staking/validators.ts (1)

345-364: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick win

Guard the pagination loop against non-advancing pages.

The loop only terminates on validators.size < total or page <= 50. If the explorer reports a total larger than what its pages actually return (or returns empty/duplicate pages), validators.size stops growing while page keeps incrementing, issuing up to ~49 extra HTTP round-trips before the cap stops it. Break early when a page yields no new entries.

♻️ Proposed fix

           total = typeof response.total === "number" ? response.total : response.validators.length;

+          const before = validators.size;
           for (const item of response.validators as ExplorerValidatorSummary[]) {
             const address = item.validator_address || item.validatorAddress;
             if (!address) continue;
             validators.set(address.toLowerCase(), this.toExplorerPerformance(item));
           }

+          if (response.validators.length === 0 || validators.size === before) break;
           page += 1;
         } while (validators.size < total && page <= 50);

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/commands/staking/validators.ts` around lines 345 - 364, The pagination
loop in the validators fetch logic can keep advancing even when a page adds no
new validators, causing unnecessary requests; update the do/while in the
validators API flow to stop early when a fetched page yields zero new entries.
Use the existing validators map and the explorer parsing block in the fetch
routine that calls this.fetchJson and toExplorerPerformance, and add a
non-advancing-page check before incrementing page so the loop exits when results
are empty or fully duplicated.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes